Repository navigation
fix(ci): treat finished checks stuck as pending as done in pr-merge - #4053
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/pr-merge.shwaited out its whole 80-minute limit on #4049. GitHub kept listing the "detect shell changes" job asin_progressafter it had finished (it had acompletedAt, its conclusion wassuccess, and the whole workflow run had completed). The script treats everypendingcheck as blocking, and it prints nothing while it waits, so it looked like a hang.gh pr checks --json name,bucket,completedAt. A pending check with a real completion time counts as passed. A check that is genuinely still running has no completion time (gh shows the0001-01-01placeholder), so it still blocks.Changelog
none
Testing
bash -n scripts/pr-merge.shpass. The other checks keep their buckets, and the advisory job filter still applies.