Skip to content

fix(ci): treat finished checks stuck as pending as done in pr-merge - #4053

Merged
LHagfoss merged 1 commit into
mainfrom
fix/ci-pr-merge-stuck-check
Nov 19, 2026
Merged

LHagfoss merged 1 commit into
mainfrom
fix/ci-pr-merge-stuck-check

Conversation

@LHagfoss

Copy link
Copy Markdown
Owner

What

scripts/pr-merge.sh waited out its whole 80-minute limit on #4049. GitHub kept listing the "detect shell changes" job as in_progress after it had finished (it had a completedAt, its conclusion was success, and the whole workflow run had completed). The script treats every pending check as blocking, and it prints nothing while it waits, so it looked like a hang.

  • Read checks with gh pr checks --json name,bucket,completedAt. A pending check with a real completion time counts as passed. A check that is genuinely still running has no completion time (gh shows the 0001-01-01 placeholder), so it still blocks.
  • Print the checks it is waiting on whenever that list changes.
  • Behaviour is otherwise the same: the advisory portability jobs are still excluded, it still needs two quiet passes, and it still fails on any failing check.

Changelog

none

Testing

@github-actions github-actions Bot added the fix A bug fix label Nov 19, 2026
@LHagfoss
LHagfoss merged commit d2e5ca6 into main Nov 19, 2026
6 checks passed
@LHagfoss
LHagfoss deleted the fix/ci-pr-merge-stuck-check branch November 19, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants